[select] fix(MultiSelect2): restore tagInputProps.onChange support #5733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This was a regression in #5730, where I updated the types to be more restrictive based on the code comment. After trying to upgrade to @blueprintjs/select 4.8.8, I found some code using
tagInputProps.onChange
in a legitimate use case. Revisiting the JSDoc comment, it turned out to be wrong -- the props we actually want to ban aretagInputProps.inputValue
andtagInputProps.onInputChange
, which nobody would be using legitimately anyway since they get overridden by the component.