Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[select] fix(MultiSelect2): restore tagInputProps.onChange support #5733

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

This was a regression in #5730, where I updated the types to be more restrictive based on the code comment. After trying to upgrade to @blueprintjs/select 4.8.8, I found some code using tagInputProps.onChange in a legitimate use case. Revisiting the JSDoc comment, it turned out to be wrong -- the props we actually want to ban are tagInputProps.inputValue and tagInputProps.onInputChange, which nobody would be using legitimately anyway since they get overridden by the component.

@adidahiya adidahiya merged commit 5ade909 into develop Nov 8, 2022
@adidahiya adidahiya deleted the ad/fix-multiselect2-props branch November 8, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants