Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix dialog layout regressions, use DialogBody more #5852

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

This fixes some layout regressions that were introduced with #5753.

Fix 1:

First, I've brought back the dialog body margin on <div className={Classes.DIALOG_BODY}> elements. We need this style to preserve backcompat of our CSS API:

Screen Shot 2023-01-17 at 5 45 20 PM

However, <DialogBody> can continue to use the (better) padding style instead of margin. This is ok because it's a new component introduced in core v4.14.0. This means that overflow scrolling still looks good:

2023-01-17 17 45 01

Fix 2:

The new MultistepDialog styles broke when there was no left section / no close button. This was due to the removal of a container element in the footer refactor in #5753. I've brought back that container element even in the case where there is no close button, and also renamed it to "main-section" instead of "left-section".

before after
Screen Shot 2023-01-17 at 5 09 32 PM Screen Shot 2023-01-17 at 5 09 41 PM

Internal enhancement:

I've migrated the rest of this monorepo to use <DialogBody> more consistently so that we can better dogfood it and prevent regressions like this.

@adidahiya
Copy link
Contributor Author

[core] fix dialog layout regressions, use DialogBody in more places

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

fix testS

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

footer-left-section -> footer-main-section

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya changed the title [core] fix dialog layout regressions, use DialogBody in more places [core] fix dialog layout regressions, use DialogBody more Jan 17, 2023
@adidahiya adidahiya merged commit 8f8136d into develop Jan 17, 2023
@adidahiya adidahiya deleted the ad/fix-dialog-styles branch January 17, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant