-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icons] feat: "intel" icon #5856
Conversation
Thanks for your interest in palantir/blueprint, @gredman2018! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CPerinet to confirm design approval 👍🏽 / 👎🏽 ?
sorry about the failing deploy-preview job -- I'll fix that -- here's the docs preview link: https://output.circle-artifacts.com/output/job/7ebf1edd-d362-4194-9fda-f8170c8baec9/artifacts/0/packages/docs-app/dist/index.html#icons |
Hi! When/how can I fix circleci deploy-preview failing? |
deploy-preview is returning a failing exit code because it's building on a fork and doesn't have the necessary environment variables. That's not a problem with your PR, just an issue with the preview script right now. It should exit gracefully with a successful exit code -- I'm going to fix that in a separate PR. In the meantime, I'll merge this PR, it's good to go |
Fixes #0000
Checklist
Changes proposed in this pull request:
Added a the new intelligence icon with 16px and 20px
Reviewers should focus on:
Everything renders correctly at both sizes!
Screenshot