Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menuDivider): role="separator" #5954

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Change menuDivider role to separator:

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/separator_role

@bvandercar-vt bvandercar-vt changed the title Bvandercar/menu divider role fix(menuDivider): role="separator" Feb 16, 2023
@adidahiya adidahiya merged commit 5286af5 into palantir:develop Feb 20, 2023
@bvandercar-vt bvandercar-vt deleted the bvandercar/menuDivider-role branch November 7, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants