Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] feat(MenuDivider): add titleId prop #5967

Merged
merged 2 commits into from
Feb 23, 2023
Merged

[core] feat(MenuDivider): add titleId prop #5967

merged 2 commits into from
Feb 23, 2023

Conversation

bvandercar-vt
Copy link
Contributor

@bvandercar-vt bvandercar-vt commented Feb 22, 2023 •
edited
Loading

add id prop so can use aria-labelledby on menuDivider title text

Checklist

  • [NA] Includes tests
  • Update documentation

@bvandercar-vt bvandercar-vt changed the title feat(menuDivider): add id prop so can use aria-labelledby on menuDivi… feat(menuDivider): add id prop Feb 22, 2023
@adidahiya adidahiya changed the title feat(menuDivider): add id prop [core] feat(MenuDivider): add titleId prop Feb 23, 2023
@adidahiya adidahiya merged commit f88e818 into palantir:develop Feb 23, 2023
@bvandercar-vt bvandercar-vt deleted the bvandercar/menuDivider-id branch November 7, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvandercar-vt @adidahiya