[core] fix(TagInput): make sure ResizableInput span is invisible #5997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adidahiya I also just noticed that when there are no tags selected the input doesn't scale with the content (it only does it when at least one tag is selected). I've found some workarounds but they're quite ugly so will refine and submit another PR for it |
@JosephChotard by "content" here, do you mean the placeholder text? |
adidahiya
reviewed
Mar 6, 2023
adidahiya
changed the title
No the actual text typed by the user. The input only expands larger when at least one tag is present. Seems to be a styling bug and not a logic one. |
adidahiya
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
In some scenarios, other styles might clash making the supposedly hidden span not invisible...
Reviewers should focus on:
Screenshot
Example of it broken:
