Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(Tag): style active modifier class correctly with intents #6014

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

andru47
Copy link
Contributor

@andru47 andru47 commented Mar 13, 2023

Fixes #6003

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

@andru47 andru47 requested a review from adidahiya March 13, 2023 13:18
@adidahiya
Copy link
Contributor

Override css and add new switch in Tag documentation

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor

Looks good, this is a strict improvement and seems to fix the issue.

However, there are still some issues with minimal tags.

In light theme, the .bp4-interactive.bp4-active style looks wrong (it should match :active):

2023-03-13 09 44 15

In dark theme, .bp4-interactive.bp5-active does nothing:

2023-03-13 09 44 32

@adidahiya
Copy link
Contributor

fixed it for you:

2023-03-13 10 33 47

@adidahiya adidahiya changed the title Fix interactive tags with intent when active [core] fix(Tag): style active modifier class correctly with intents Mar 13, 2023
@adidahiya
Copy link
Contributor

fix minimal tag styling

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@andru47 andru47 merged commit 168ce55 into develop Mar 13, 2023
@adidahiya adidahiya deleted the as/fix-tag branch March 13, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive tags with intent have wrong background color when active
2 participants