[node-build-scripts] feat: downgrade to Node v18 #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
commented
Mar 24, 2023
| @@ -56,7 +56,7 @@ | |||
| "ts-jest": "^29.0.5" | |||
| }, | |||
| "engines": { | |||
| "node": ">=19.3" | |||
| "node": ">=18.13" | |||
There was a problem hiding this comment.
I picked a relatively recent version of v18 (Jan 2023) here while avoiding constraining this range to the most recent release.
[node-build-scripts] feat: downgrade to Node v18Build artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
changed the title
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Node.js release schedule, v19 is going to be very short-lived. It doesn't make sense for us to require that version when it's going to be EOL in June 2023.
I've downgraded to Node v18 here, which will be supported for 2 more years in LTS.