Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[select] fix(Select2): fix regression in keyboard closing behavior #6163

Merged
merged 1 commit into from
May 16, 2023

Conversation

adidahiya
Copy link
Contributor

Fixes issue in #6092 (review)

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Fix a regression caused by #6149. Implicit type coercion was the culprit!

@adidahiya adidahiya changed the title [select] fix(Select): fix regression in keyboard closing behavior [select] fix(Select2): fix regression in keyboard closing behavior May 16, 2023
@adidahiya
Copy link
Contributor Author

[select] fix(Select): fix regression in keyboard closing behavior

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

Interactions look good in docs preview, no console errors:

2023-05-16 11 26 29

@adidahiya adidahiya merged commit 0d174ac into develop May 16, 2023
@adidahiya adidahiya deleted the ad/fix-select-close-enter branch May 16, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant