[table] fix: hide frozen quadrant scrollbar when zoomed out #6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
commented
May 23, 2023
| @@ -146,11 +146,3 @@ $menu-z-index: $row-z-index + 1 !default; | |||
| display: inline-block; | |||
| position: absolute; | |||
| } | |||
|
|
|||
| .#{$ns}-table-scrollbar-measure { | |||
There was a problem hiding this comment.
this class was apparently unused. I guess we removed whatever code we had to detect scrollbar width.
[table] fix: hide frozen quadrant scrollbar when zoomed outBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
fix lint?Build artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
|
Removing the 
|
add back vendor prefixBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6172
Checklist
Changes proposed in this pull request:
Update existing CSS which attempts to hide frozen table quadrant scrollbars. We now use media queries to apply different scrollbar width offsets so that this "feature" works on different display pixel densities (this is the easiest way to detect zoom level in CSS).
Reviewers should focus on:
Whether this fixes the bug and causes no regressions in table scrolling in Chrome, Edge, and Firefox.
Screenshot