[core] fix(SectionCard): rename component, fix Sass variable names #6272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
_section.scss
to match naming used in other parts of the Sass codebase (_tooltip.scss
,button/_common.scss
)Section
): add support forelevation
prop which accepts a subset of the possibleElevation
values (ZERO and ONE)Reviewers should focus on:
Naming for the SectionCard component. It's a bit tricky to name container elements like this, but I feel like this is probably the best option for now. It's not:
references:
Screenshot