Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export private component types which are part of public API #6293

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Jul 20, 2023

Changes proposed in this pull request:

  • [core] fix: export IconComponent type (previously named GenericIcon) in public API
  • [icons] fix: export SVGIconContainerComponent type (previously named GenericSVGIconContainer) in public API

Before this change, users may have received a TS compilation error when trying to re-export Icon or SVGIconContainer as TS would attempt to reference a private type symbol:

error TS4023: Exported variable '[redacted]' has or is using name 'GenericIcon' from external module "/home/circleci/project/node_modules/.pnpm/@blueprintjs+core@5.1.4_ugrpyuvudjf6jbttetu7vnqf5m/node_modules/@blueprintjs/core/lib/esm/components/icon/icon" but cannot be named.

@adidahiya
Copy link
Contributor Author

fix: export private component types which are part of public API

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 7ebfe22 into develop Jul 20, 2023
@adidahiya adidahiya deleted the ad/generic-icon branch July 20, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant