Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Section): Add controlled mode support #6328

Merged
merged 5 commits into from
Aug 28, 2023
Merged

feat(Section): Add controlled mode support #6328

merged 5 commits into from
Aug 28, 2023

Conversation

nerdstep
Copy link
Contributor

@nerdstep nerdstep commented Aug 21, 2023 •
edited
Loading

Resolves #6323

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Implementation & documentation.

Screenshot

image

@nerdstep nerdstep marked this pull request as ready for review August 21, 2023 17:24
@adidahiya adidahiya self-requested a review August 25, 2023 13:56
adidahiya
adidahiya suggested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thorough PR, thanks for adding unit tests!

just a few minor points of feedback. we should be able to merge this soon.

packages/docs-app/src/examples/core-examples/sectionExample.tsx Show resolved Hide resolved
packages/docs-app/src/examples/core-examples/sectionExample.tsx Outdated Show resolved Hide resolved
packages/core/src/components/section/section.tsx Outdated Show resolved Hide resolved
packages/core/src/components/section/section.tsx Outdated Show resolved Hide resolved
adidahiya
adidahiya approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in docs preview build, thanks @nerdstep

@adidahiya adidahiya merged commit 31988f9 into palantir:develop Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Section component controlled state
2 participants
@nerdstep @adidahiya