[core] fix(RangeSlider): render handle correctly on first mount in popover #6338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4417
Checklist
Changes proposed in this pull request:
Update DOM measurement code to use
element.offsetWidth
andelement.offsetHeight
to get an accurateDOMRect
for the handle element.Credit to @pgoldberg for diving in to diagnose the issue and coming up with this potential solution 👍🏽
Reviewers should focus on:
No regressions in Slider & RangeSlider behavior
Screenshot
Without the implementation change:
After adjusting to use
offsetWidth
andoffsetHeight
: