Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(RangeSlider): render handle correctly on first mount in popover #6338

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Aug 28, 2023

Fixes #4417

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Update DOM measurement code to use element.offsetWidth and element.offsetHeight to get an accurate DOMRect for the handle element.

Credit to @pgoldberg for diving in to diagnose the issue and coming up with this potential solution 👍🏽

Reviewers should focus on:

No regressions in Slider & RangeSlider behavior

Screenshot

Without the implementation change:

image

After adjusting to use offsetWidth and offsetHeight:

image

@adidahiya
Copy link
Contributor Author

[core] fix(RangeSlider): render handle correctly on first mount in popover

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 7897e39 into develop Aug 28, 2023
@adidahiya adidahiya deleted the ad/fix-slider-in-popover-bug branch August 28, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range Slider Handles inside a popover not fixed properly onOpen
1 participant