Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datetime] deprecate react-day-picker v7 components #6402

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Sep 22, 2023

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • [datetime] ⚠️ deprecation(DatePicker, DateInput, DateRangePicker, DateRangeInput): components which use react-day-picker v7.x are now deprecated in favor of the newer "v3" components which use react-day-picker v8.x
  • [eslint-plugin] feat(no-deprecated-components, no-deprecated-datetime-components): report deprecated react-day-picker v7.x components
    • 🔥 this is a breaking change
  • [eslint-plugin] feat(no-deprecated-datetime2-components): new lint rule to flag usage of DateInput2 and DateRangeInput2

Things to note:

After this, I will release major versions of:

  • @blueprintjs/eslint-plugin
  • @blueprintjs/datetime2
    • N.B. v1.1.0-alpha.0 had a slight breaking change in that it required consumers to enable allowSyntheticDefaultImports in their TypeScript config, so I am opting to release v2.0.0 with this break

Screenshot

image
image
image

@adidahiya
Copy link
Contributor Author

DateRangeInput is missing a deprecation message:

image

we also might want to update the datetime package docs index page:

image

@adidahiya
Copy link
Contributor Author

feat: no-deprecated-datetime2-components lint rule

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 0c69a76 into develop Sep 25, 2023
@adidahiya adidahiya deleted the ad/deprecate-datetime-components branch September 25, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant