[core] fix(Popover): 'lazy' support; add tests for 'shouldReturnFocusOnClose' #6579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
commented
Nov 30, 2023
update docs exampleBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
address self-reviewBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
commented
Dec 1, 2023
| @@ -290,18 +346,6 @@ describe("<Popover>", () => { | |||
| autoFocus: false, | |||
| }); | |||
| }); | |||
|
|
|||
| it("popover remains open after target focus if autoFocus={true}", () => { | |||
There was a problem hiding this comment.
this test doesn't really make sense since autoFocus is disabled for "hover" popovers. it should be removed. see code:
remove invalid testBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
lazyprop support forPopover(the component was never forwarding that prop toOverlay)shouldReturnFocusOnClosebehavior, illustrating that this requiresopenOnTargetFocus={false}andshouldReturnFocusOnClose={true}to be setshouldReturnFocusOnClosedemo to docs exampleReviewers should focus on:
Unit test behavior
Screenshot