Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[echan & ncai] Compact callout #6592

Merged
merged 7 commits into from
Jan 31, 2024

Conversation

eugenechantk
Copy link
Contributor

@eugenechantk eugenechantk commented Dec 7, 2023

Checklist

  • [N/A] Includes tests
  • Update documentation

Changes proposed in this pull request:

  • feat(Callout): new compact prop allows using a compact visual appearance

Reviewers should focus on:

Styling of new modifier prop / class

Screenshot

coming soon

@eugenechantk eugenechantk marked this pull request as draft December 7, 2023 22:54
@adidahiya
Copy link
Contributor

@eugenechantk I updated this PR:

  • pulled in develop
  • reverted the H5->H6 change (what was the motivation for this?)
  • fixed padding styles in regular & compact mode
  • added a "compact" switch to the callout docs example
    • refactored the callout example component to be an FC (ongoing migration as we touch existing code)

image
image

@adidahiya adidahiya marked this pull request as ready for review January 26, 2024 15:43
@adidahiya
Copy link
Contributor

Note that there is an unrelated bug on develop which has been merged into this PR; I'm working on a fix: #6679

@adidahiya
Copy link
Contributor

Going to merge this for now without the heading size change -- we might consider doing that in a separate PR.

@adidahiya adidahiya merged commit b3bb648 into palantir:develop Jan 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants