[icons]: team, trophy, soccer ball, sports stadium #6627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up PR a bitBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
suggested changes
Jan 5, 2024
| @@ -0,0 +1,12 @@ | |||
| <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
| <g clip-path="url(#clip0_1_17)"> | |||
There was a problem hiding this comment.
I think the <g> wrapper and <defs> are superfluous, they should probably be removed from this file
| @@ -0,0 +1,5 @@ | |||
| <svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
this version of the sports-stadium icon markup looks better 👍
resources/icons/20px/trophy.svg
Outdated
| @@ -0,0 +1,10 @@ | |||
| <svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
| <g clip-path="url(#clip0_1_13)"> | |||
There was a problem hiding this comment.
same here, we should remove the <g> wrapper and the <defs> block
|
Oh hm, would you mind making those changes? Not sure why those are there - is it due to something in the icon SVG? |
|
@jessperrin I'm not sure either, probably something to do with Figma export. Sure, I can make those fixes |
remove extraneous SVG markupBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
Soccer-based icons for an sports pilot.