[core] fix(ContextMenuPopover): clean up document handlers on close #6685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
commented
Jan 30, 2024
| @@ -183,7 +186,7 @@ export class DrawerExample extends React.PureComponent<ExampleProps<BlueprintExa | |||
| } | |||
|
|
|||
| const SIZES: Array<string | OptionProps> = [ | |||
| { label: "Default", value: undefined }, | |||
| { label: "Default", value: "default" }, | |||
There was a problem hiding this comment.
note that this fixes a minor React warning about a missing "key" on HTMLSelect children in this example
Update packages/core/src/common/utils/mountOptions.tsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6684
Checklist
Changes proposed in this pull request:
ContextMenuPopover): clean up document handlers on close to allow normal scroll interactions to resumeContextMenuPopover): support configuration of DOM mounting / unmounting methods in imperativeshowContextMenu/hideContextMenuAPIsOverlayToaster(Update OverlayToaster component to use ReactDOM.createRoot() for React 18 compatibility #6239)Reviewers should focus on:
Fixes the linked bug
Screenshot