Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show slider fill before value equal to initial value #6853

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

evansjohnson
Copy link
Contributor

Fixes #6844

Checklist

  • Includes tests
  • [n/a] Update documentation

Changes proposed in this pull request:

I can't think of a reason a user would want the track to be filled from min to value when value === initial value, but then have value to initial value filled when value is just slightly less.

I imagine this case just wasn't explicitly considered, since often min may equal initial value and this issue is not apparent.

Reviewers should focus on:

If there's any valid use case for this track fill behavior.

Screenshot

Issue observable on slider example if showing fill for bottom example
Screenshot 2024-06-18 at 10 19 00 AM
Screenshot 2024-06-18 at 10 18 57 AM
Screenshot 2024-06-18 at 10 18 54 AM

@svc-palantir-github
Copy link

don't show slider fill before value equal to initial value

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@gluxon gluxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a reason a user would want the track to be filled from min to value when value === initial value, but then have value to initial value filled when value is just slightly less.

Agree. Thanks for this fix!

@evansjohnson evansjohnson merged commit 6273c37 into develop Jun 19, 2024
14 checks passed
@evansjohnson evansjohnson deleted the evanj/slider-fill-fix branch June 19, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider fill with negative min, positive max, initialValue of 0 has the wrong track fill at zero
3 participants