Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Input icons and added new Output icons #6922

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

alex-dales
Copy link
Contributor

Summary of changes

  • Updated existing Input icon for both 16px and 20px
  • Added new Output icon for both 16px and 20px
Screenshot 2024-07-23 at 1 34 00 PM

@alex-dales alex-dales requested a review from evansjohnson July 23, 2024 17:35
@changelog-app
Copy link

changelog-app bot commented Jul 23, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Updated Input icons and added new Output icons

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Updated Input icons and added new Output icons

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

evansjohnson
evansjohnson previously approved these changes Jul 24, 2024
Copy link
Contributor

@evansjohnson evansjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@policy-bot policy-bot bot dismissed evansjohnson’s stale review July 24, 2024 16:58

Invalidated by push of 42e9d24

@svc-palantir-github
Copy link

resolve conflicts

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Merge branch 'develop' into ad/input-output-icons

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Co-authored-by: Evan Johnson <esj254@nyu.edu>
@svc-palantir-github
Copy link

Update packages/icons/icons.json

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@evansjohnson evansjohnson merged commit 67daadd into develop Jul 25, 2024
12 of 14 checks passed
@evansjohnson evansjohnson deleted the ad/input-output-icons branch July 25, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants