Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add range ring icon #6929

Merged
merged 4 commits into from
Aug 21, 2024
Merged

add range ring icon #6929

merged 4 commits into from
Aug 21, 2024

Conversation

jmorgpal
Copy link
Contributor

@jmorgpal jmorgpal commented Aug 1, 2024

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

@changelog-app
Copy link

changelog-app bot commented Aug 1, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

add range ring icon

Check the box to generate changelog(s)

  • Generate changelog entry

@ericjeney
Copy link
Contributor

@alex-dales approved the design

ggdouglas
ggdouglas reviewed Aug 13, 2024
View reviewed changes
resources/icons/16px/range-ring.svg
<rect width="16" height="16" fill="white"/>
</clipPath>
</defs>
</svg>
Copy link
Contributor

@ggdouglas ggdouglas Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can clean up some of the SVG markup here. The <clipPath>, <rect>, group, and fill/clip rules all seem unnecessary. Additionally, I think we can remove all fills and let the path inherit the default fill color.

<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
  <path d="M8 0C7.64677 0 7.29839 0.0229549 6.95639 0.0675665C6.40874 0.139002 6.0227 0.640866 6.09414 1.18851C6.16557 1.73616 6.66744 2.1222 7.21508 2.05077C7.47153 2.01731 7.73349 2 8 2C8.26651 2 8.52847 2.01731 8.78492 2.05077C9.33256 2.1222 9.83443 1.73616 9.90586 1.18851C9.9773 0.640866 9.59126 0.139002 9.04361 0.0675663C8.70161 0.0229549 8.35323 0 8 0ZM4.34784 3.23912C4.78576 2.9026 4.86795 2.27479 4.53143 1.83688C4.19491 1.39896 3.5671 1.31676 3.12918 1.65328C2.57534 2.07889 2.07889 2.57534 1.65328 3.12918C1.31676 3.5671 1.39896 4.19491 1.83688 4.53143C2.27479 4.86795 2.9026 4.78576 3.23912 4.34784C3.55881 3.93183 3.93183 3.55881 4.34784 3.23912ZM12.8708 1.65328C12.4329 1.31676 11.8051 1.39896 11.4686 1.83688C11.132 2.27479 11.2142 2.9026 11.6522 3.23912C12.0682 3.55881 12.4412 3.93183 12.7609 4.34784C13.0974 4.78576 13.7252 4.86795 14.1631 4.53143C14.601 4.19491 14.6832 3.5671 14.3467 3.12918C13.9211 2.57534 13.4247 2.07889 12.8708 1.65328ZM15.9324 6.95639C15.861 6.40874 15.3591 6.0227 14.8115 6.09414C14.2638 6.16557 13.8778 6.66744 13.9492 7.21508C13.9827 7.47153 14 7.73349 14 8C14 8.26651 13.9827 8.52847 13.9492 8.78492C13.8778 9.33256 14.2638 9.83443 14.8115 9.90586C15.3591 9.9773 15.861 9.59126 15.9324 9.04361C15.977 8.70161 16 8.35323 16 8C16 7.64677 15.977 7.29839 15.9324 6.95639ZM2.05077 7.21508C2.1222 6.66744 1.73616 6.16557 1.18851 6.09414C0.640866 6.0227 0.139002 6.40875 0.0675663 6.95639C0.0229549 7.29839 0 7.64677 0 8C0 8.35323 0.0229549 8.70161 0.0675665 9.04361C0.139002 9.59126 0.640866 9.9773 1.18851 9.90586C1.73616 9.83443 2.1222 9.33256 2.05077 8.78492C2.01731 8.52847 2 8.26651 2 8C2 7.73349 2.01731 7.47153 2.05077 7.21508ZM3.23912 11.6522C2.9026 11.2142 2.27479 11.132 1.83688 11.4686C1.39896 11.8051 1.31676 12.4329 1.65328 12.8708C2.07889 13.4247 2.57534 13.9211 3.12918 14.3467C3.5671 14.6832 4.19491 14.601 4.53143 14.1631C4.86795 13.7252 4.78576 13.0974 4.34784 12.7609C3.93183 12.4412 3.55881 12.0682 3.23912 11.6522ZM14.3467 12.8708C14.6832 12.4329 14.601 11.8051 14.1631 11.4686C13.7252 11.132 13.0974 11.2142 12.7609 11.6522C12.4412 12.0682 12.0682 12.4412 11.6522 12.7609C11.2142 13.0974 11.132 13.7252 11.4686 14.1631C11.8051 14.601 12.4329 14.6832 12.8708 14.3467C13.4247 13.9211 13.9211 13.4247 14.3467 12.8708ZM9.04361 15.9324C9.59126 15.861 9.9773 15.3591 9.90586 14.8115C9.83443 14.2638 9.33256 13.8778 8.78492 13.9492C8.52847 13.9827 8.26651 14 8 14C7.73349 14 7.47153 13.9827 7.21508 13.9492C6.66744 13.8778 6.16557 14.2638 6.09414 14.8115C6.0227 15.3591 6.40875 15.861 6.95639 15.9324C7.29839 15.977 7.64677 16 8 16C8.35323 16 8.70161 15.977 9.04361 15.9324ZM8 6C9.10457 6 10 6.89543 10 8C10 9.10457 9.10457 10 8 10C6.89543 10 6 9.10457 6 8C6 6.89543 6.89543 6 8 6ZM12 8C12 5.79086 10.2091 4 8 4C5.79086 4 4 5.79086 4 8C4 10.2091 5.79086 12 8 12C10.2091 12 12 10.2091 12 8Z" />
</svg>
20px-range-ring

ggdouglas
ggdouglas reviewed Aug 13, 2024
View reviewed changes
resources/icons/20px/range-ring.svg
<rect width="20" height="20" fill="white"/>
</clipPath>
</defs>
</svg>
Copy link
Contributor

@ggdouglas ggdouglas Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

<svg viewBox="0 0 20 20" xmlns="http://www.w3.org/2000/svg">
  <path d="M10 0C9.55823 0 9.12267 0.0287076 8.69517 0.084471C8.14753 0.155907 7.76148 0.657771 7.83292 1.20542C7.90435 1.75306 8.40622 2.13911 8.95386 2.06767C9.29581 2.02307 9.64496 2 10 2C10.355 2 10.7042 2.02307 11.0461 2.06767C11.5938 2.13911 12.0956 1.75306 12.1671 1.20542C12.2385 0.657771 11.8525 0.155907 11.3048 0.084471C10.8773 0.0287076 10.4418 0 10 0ZM5.13027 3.65232C5.56819 3.3158 5.65038 2.688 5.31386 2.25008C4.97734 1.81216 4.34953 1.72996 3.91162 2.06649C3.21922 2.59856 2.59856 3.21922 2.06649 3.91162C1.72996 4.34953 1.81216 4.97734 2.25008 5.31386C2.688 5.65038 3.3158 5.56819 3.65232 5.13027C4.07848 4.57571 4.57571 4.07848 5.13027 3.65232ZM16.0884 2.06649C15.6505 1.72996 15.0227 1.81216 14.6861 2.25008C14.3496 2.688 14.4318 3.3158 14.8697 3.65232C15.4243 4.07848 15.9215 4.57571 16.3477 5.13027C16.6842 5.56819 17.312 5.65038 17.7499 5.31386C18.1878 4.97734 18.27 4.34953 17.9335 3.91162C17.4014 3.21922 16.7808 2.59856 16.0884 2.06649ZM2.06767 8.95386C2.13911 8.40622 1.75306 7.90435 1.20542 7.83292C0.657771 7.76148 0.155907 8.14753 0.084471 8.69517C0.0287076 9.12267 0 9.55823 0 10C0 10.4418 0.0287076 10.8773 0.084471 11.3048C0.155907 11.8525 0.657771 12.2385 1.20542 12.1671C1.75306 12.0956 2.13911 11.5938 2.06767 11.0461C2.02307 10.7042 2 10.355 2 10C2 9.64496 2.02307 9.29581 2.06767 8.95386ZM19.9155 8.69517C19.8441 8.14753 19.3422 7.76148 18.7946 7.83292C18.2469 7.90435 17.8609 8.40622 17.9323 8.95386C17.9769 9.29581 18 9.64496 18 10C18 10.355 17.9769 10.7042 17.9323 11.0461C17.8609 11.5938 18.2469 12.0956 18.7946 12.1671C19.3422 12.2385 19.8441 11.8525 19.9155 11.3048C19.9713 10.8773 20 10.4418 20 10C20 9.55823 19.9713 9.12267 19.9155 8.69517ZM3.65232 14.8697C3.3158 14.4318 2.688 14.3496 2.25008 14.6861C1.81216 15.0227 1.72996 15.6505 2.06649 16.0884C2.59856 16.7808 3.21922 17.4014 3.91162 17.9335C4.34953 18.27 4.97734 18.1878 5.31386 17.7499C5.65038 17.312 5.56819 16.6842 5.13027 16.3477C4.57571 15.9215 4.07848 15.4243 3.65232 14.8697ZM17.9335 16.0884C18.27 15.6505 18.1878 15.0227 17.7499 14.6861C17.312 14.3496 16.6842 14.4318 16.3477 14.8697C15.9215 15.4243 15.4243 15.9215 14.8697 16.3477C14.4318 16.6842 14.3496 17.312 14.6861 17.7499C15.0227 18.1878 15.6505 18.27 16.0884 17.9335C16.7808 17.4014 17.4014 16.7808 17.9335 16.0884ZM8.95386 17.9323C8.40622 17.8609 7.90435 18.2469 7.83292 18.7946C7.76148 19.3422 8.14753 19.8441 8.69517 19.9155C9.12267 19.9713 9.55823 20 10 20C10.4418 20 10.8773 19.9713 11.3048 19.9155C11.8525 19.8441 12.2385 19.3422 12.1671 18.7946C12.0956 18.2469 11.5938 17.8609 11.0461 17.9323C10.7042 17.9769 10.355 18 10 18C9.64496 18 9.29581 17.9769 8.95386 17.9323ZM10 7C11.6569 7 13 8.34315 13 10C13 11.6569 11.6569 13 10 13C8.34315 13 7 11.6569 7 10C7 8.34315 8.34315 7 10 7ZM15 10C15 7.23858 12.7614 5 10 5C7.23858 5 5 7.23858 5 10C5 12.7614 7.23858 15 10 15C12.7614 15 15 12.7614 15 10Z" />
</svg>
20px-range-ring

@ggdouglas ggdouglas merged commit 4111fc8 into palantir:develop Aug 21, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggdouglas ggdouglas ggdouglas approved these changes

Assignees

@ggdouglas ggdouglas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmorgpal @ericjeney @ggdouglas