Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce opacity of disabled checkbox control indicator #6962

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Sep 4, 2024

Fixes #6734

Changes proposed in this pull request:

Updates checkbox control indicators (tick and indeterminate dash) on disabled checkbox controls to use a reduced opacity. This aligns with design intent and provides better signal that the checkbox control is disabled.

Reviewers should focus on:

Checkbox and Checkbox card

Screenshot

Before After
before after

Accessibility / Contrast Check

Light Mode
Screenshot 2024-09-05 at 11 42 09@2x
https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF80&bcolor=99B8E9
WCAG AA: Fail (Graphical Objects and User Interface Components)

Dark Mode
Screenshot 2024-09-05 at 11 42 03@2x
https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF80&bcolor=25497D
WCAG AA: Pass (Graphical Objects and User Interface Components)

@changelog-app
Copy link

changelog-app bot commented Sep 4, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Reduce opacity of disabled checkbox control indicator

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Reduce opacity of disabled checkbox control indicator

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Member

@invliD invliD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to W3C, high contrast is not required for disabled elements, so this change is fine.

User Interface Components that are not available for user interaction (e.g., a disabled control in HTML) are not required to meet contrast requirements.

@ggdouglas ggdouglas merged commit b3f5a3d into develop Sep 5, 2024
12 of 14 checks passed
@ggdouglas ggdouglas deleted the gdouglas/fix-checkbox-opacity branch September 5, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled checkbox check icon has confusing fill opacity
3 participants