style: simplify test assertions #6983

bvandercar-vt · 2024-09-17T21:12:27Z

No description provided.

changelog-app · 2024-09-17T21:12:34Z

Generate changelog in `packages/core/changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

style: simplify test assertions

Generate changelog in `packages/datetime2/changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

style: simplify test assertions

Generate changelog in `packages/select/changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

style: simplify test assertions

Generate changelog in `packages/stylelint-plugin/changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

style: simplify test assertions

Generate changelog in `packages/table/changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

style: simplify test assertions

Check the box to generate changelog(s)

Generate changelog entry

ggdouglas

A couple small comments, but the reset generally LGTM

ggdouglas · 2024-09-18T15:27:50Z

packages/table/test/quadrants/tableQuadrantTests.tsx

            });

            it("does not render menu if menuRenderer not provided", () => {
                const component = mountTableQuadrant();
-                expect(component.find(`.${Classes.TABLE_TOP_CONTAINER}`).children().length).to.equal(0);
+                expect(component.find(`.${Classes.TABLE_TOP_CONTAINER}`).children()).to.have.lengthOf(0);


nit: .to.be.empty seems a bit more appropriate for this type of check:

Suggested change

expect(component.find(`.${Classes.TABLE_TOP_CONTAINER}`).children()).to.have.lengthOf(0);

expect(component.find(`.${Classes.TABLE_TOP_CONTAINER}`).children()).to.be.empty;

Sure, done!

ggdouglas · 2024-09-18T15:29:26Z

packages/table/test/regionsTests.ts

@@ -238,7 +238,7 @@ describe("Regions", () => {
        ];

        const joinedGroups = Regions.joinStyledRegionGroups([Regions.row(2)], myGroups, undefined);
-        expect(joinedGroups).to.have.lengthOf(2);
+        expect(joinedGroups).to.have.to.have.lengthOf(2);


nit: duplicate chain for assertions in this file:

Suggested change

expect(joinedGroups).to.have.to.have.lengthOf(2);

expect(joinedGroups).to.have.lengthOf(2);

Good catch. Fixed

ggdouglas

Nice work, thanks for the cleanup!

style: simplify test assertions

51478a1

ggdouglas reviewed Sep 18, 2024

View reviewed changes

bvandercar-vt added 3 commits September 18, 2024 09:52

more changes

72a458e

remove duplicate chainer

4d24dd4

replace .to.have.lengthOf(0) with .to.be.empty

f5f1a18

ggdouglas approved these changes Sep 18, 2024

View reviewed changes

ggdouglas merged commit dbb1adb into palantir:develop Sep 18, 2024
12 of 19 checks passed

bvandercar-vt deleted the bvandercar/test-simplify-assertions branch November 7, 2024 19:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style: simplify test assertions #6983

style: simplify test assertions #6983

bvandercar-vt commented Sep 17, 2024

changelog-app bot commented Sep 17, 2024

ggdouglas left a comment

ggdouglas Sep 18, 2024

bvandercar-vt Sep 18, 2024

ggdouglas Sep 18, 2024

bvandercar-vt Sep 18, 2024

ggdouglas left a comment

	expect(component.find(`.${Classes.TABLE_TOP_CONTAINER}`).children()).to.have.lengthOf(0);
	expect(component.find(`.${Classes.TABLE_TOP_CONTAINER}`).children()).to.be.empty;

	expect(joinedGroups).to.have.to.have.lengthOf(2);
	expect(joinedGroups).to.have.lengthOf(2);

style: simplify test assertions #6983

style: simplify test assertions #6983

Conversation

bvandercar-vt commented Sep 17, 2024

changelog-app bot commented Sep 17, 2024

Generate changelog in packages/core/changelog/@unreleased

Generate changelog in packages/datetime2/changelog/@unreleased

Generate changelog in packages/select/changelog/@unreleased

Generate changelog in packages/stylelint-plugin/changelog/@unreleased

Generate changelog in packages/table/changelog/@unreleased

ggdouglas left a comment

Choose a reason for hiding this comment

ggdouglas Sep 18, 2024

Choose a reason for hiding this comment

bvandercar-vt Sep 18, 2024

Choose a reason for hiding this comment

ggdouglas Sep 18, 2024

Choose a reason for hiding this comment

bvandercar-vt Sep 18, 2024

Choose a reason for hiding this comment

ggdouglas left a comment

Choose a reason for hiding this comment

Generate changelog in `packages/core/changelog/@unreleased`

Generate changelog in `packages/datetime2/changelog/@unreleased`

Generate changelog in `packages/select/changelog/@unreleased`

Generate changelog in `packages/stylelint-plugin/changelog/@unreleased`

Generate changelog in `packages/table/changelog/@unreleased`