add british pound icons #7018
Merged
add british pound icons #7018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggdouglas
reviewed
Oct 22, 2024
| @@ -0,0 +1,3 @@ | |||
| <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
| <path d="M7.00009 5C7.00009 4.73736 7.05182 4.47729 7.15233 4.23463C7.25284 3.99198 7.40016 3.7715 7.58588 3.58579C7.77159 3.40007 7.99207 3.25275 8.23472 3.15224C8.47737 3.05173 8.73745 3 9.00009 3C9.26273 3 9.52281 3.05173 9.76546 3.15224C10.0081 3.25275 10.2286 3.40007 10.4143 3.58579C10.6 3.7715 10.7473 3.99198 10.8478 4.23463L12.6956 3.46927C12.4946 2.98396 12.2 2.54301 11.8285 2.17157C11.4571 1.80014 11.0161 1.5055 10.5308 1.30448C10.0455 1.10346 9.52538 1 9.00009 1C8.4748 1 7.95466 1.10346 7.46936 1.30448C6.98405 1.5055 6.5431 1.80014 6.17166 2.17157C5.80023 2.54301 5.50559 2.98396 5.30457 3.46927C5.10355 3.95457 5 4.47471 5 5V7H4C3.44772 7 3 7.44772 3 8C3 8.55228 3.44772 9 4 9H5V10.5C5 11.6331 4.77099 12.2907 4.54295 12.6328C4.3327 12.9482 4.12995 13 4 13H3V15H13V13H6.591C6.86122 12.3158 7 11.4782 7 10.5V9H10C10.5523 9 11 8.55229 11 8C11 7.44772 10.5523 7 10 7H7L7.00009 5Z" fill="black"/> | |||
| </svg> | |||
There was a problem hiding this comment.
Can we omit the width, height, and fill properties on the svg and path elements? They aren't necessary:
<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
<path d="M7.00009 5C7.00009 4.73736 7.05182 4.47729 7.15233 4.23463C7.25284 3.99198 7.40016 3.7715 7.58588 3.58579C7.77159 3.40007 7.99207 3.25275 8.23472 3.15224C8.47737 3.05173 8.73745 3 9.00009 3C9.26273 3 9.52281 3.05173 9.76546 3.15224C10.0081 3.25275 10.2286 3.40007 10.4143 3.58579C10.6 3.7715 10.7473 3.99198 10.8478 4.23463L12.6956 3.46927C12.4946 2.98396 12.2 2.54301 11.8285 2.17157C11.4571 1.80014 11.0161 1.5055 10.5308 1.30448C10.0455 1.10346 9.52538 1 9.00009 1C8.4748 1 7.95466 1.10346 7.46936 1.30448C6.98405 1.5055 6.5431 1.80014 6.17166 2.17157C5.80023 2.54301 5.50559 2.98396 5.30457 3.46927C5.10355 3.95457 5 4.47471 5 5V7H4C3.44772 7 3 7.44772 3 8C3 8.55228 3.44772 9 4 9H5V10.5C5 11.6331 4.77099 12.2907 4.54295 12.6328C4.3327 12.9482 4.12995 13 4 13H3V15H13V13H6.591C6.86122 12.3158 7 11.4782 7 10.5V9H10C10.5523 9 11 8.55229 11 8C11 7.44772 10.5523 7 10 7H7L7.00009 5Z"/>
</svg>
| @@ -0,0 +1,3 @@ | |||
| <svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
| <path d="M8.9999 6C8.9999 5.20435 9.31597 4.44129 9.87858 3.87868C10.4412 3.31607 11.2043 3 11.9999 3C12.7956 3 13.5586 3.31607 14.1212 3.87868L16.2425 1.75736C15.1173 0.632141 13.5912 0 11.9999 0C10.4086 0 8.88248 0.632142 7.75726 1.75736C6.63205 2.88258 5.9999 4.4087 5.9999 6L6 9H4C3.44772 9 3 9.44771 3 10V11C3 11.5523 3.44771 12 4 12H6V14.5C6 15.5501 5.64632 16.1408 5.28801 16.4758C4.89686 16.8415 4.39566 17 4 17H3V20H18V17H8.5092C8.82325 16.2813 9 15.445 9 14.5V12H13C13.5523 12 14 11.5523 14 11V10C14 9.44772 13.5523 9 13 9H9L8.9999 6Z" fill="black"/> | |||
| </svg> | |||
There was a problem hiding this comment.
Same here:
<svg viewBox="0 0 20 20" xmlns="http://www.w3.org/2000/svg">
<path d="M8.9999 6C8.9999 5.20435 9.31597 4.44129 9.87858 3.87868C10.4412 3.31607 11.2043 3 11.9999 3C12.7956 3 13.5586 3.31607 14.1212 3.87868L16.2425 1.75736C15.1173 0.632141 13.5912 0 11.9999 0C10.4086 0 8.88248 0.632142 7.75726 1.75736C6.63205 2.88258 5.9999 4.4087 5.9999 6L6 9H4C3.44772 9 3 9.44771 3 10V11C3 11.5523 3.44771 12 4 12H6V14.5C6 15.5501 5.64632 16.1408 5.28801 16.4758C4.89686 16.8415 4.39566 17 4 17H3V20H18V17H8.5092C8.82325 16.2813 9 15.445 9 14.5V12H13C13.5523 12 14 11.5523 14 11V10C14 9.44772 13.5523 9 13 9H9L8.9999 6Z"/>
</svg>
ggdouglas
previously approved these changes
Oct 22, 2024
policy-bot
bot
dismissed
ggdouglas’s stale review
Invalidated by push of 513d372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
Adding a british pound icon
Reviewers should focus on:
Screenshot