-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebump JNA with LIBFFI_TMPDIR #443
Conversation
build.xml
Outdated
@@ -416,7 +416,7 @@ | |||
<exclusion groupId="hsqldb" artifactId="hsqldb"/> <!-- outdated version --> | |||
<exclusion groupId="antlr" artifactId="antlr"/> <!-- outdated version --> | |||
</dependency> | |||
<dependency groupId="net.java.dev.jna" artifactId="jna" version="4.0.0"/> | |||
<dependency groupId="net.java.dev.jna" artifactId="jna" version="5.8.0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be at least 5.10.0 to pick up the fix java-native-access/jna#1378
<dependency groupId="net.java.dev.jna" artifactId="jna" version="5.8.0"/> | |
<dependency groupId="net.java.dev.jna" artifactId="jna" version="5.13.0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would support using 5.13, as that's what's used on Cassandra trunk https://github.com/apache/cassandra/blob/830f88d4ab2aaa1f7b88b90747a808d0a4e2a708/.build/parent-pom-template.xml#L548
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should bump JNA to at least 5.10.0, although latest is 5.13.0, see https://github.com/java-native-access/jna/blob/master/CHANGES.md
Co-authored-by: David Schlosnagle <davids@palantir.com>
Co-authored-by: David Schlosnagle <davids@palantir.com>
SHA256 of jna-5.13.0.jar: |
Validated https://github.com/palantir/cassandra/raw/3c64de216ed4079d5ce2be8936599aa278a7439c/lib/jna-5.13.0.jar against https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.13.0/jna-5.13.0.jar.sha1 and locally
|
Tested Cassandra is booting up healthy even when tmpfs is mounted noexec |
Unable to release palantir-cassandra-2.2.18 since the branch protections rules include administrators. Please modify the rule. |
This reverts commit 5816ffc.