fix: codecs.GZIP checks error before defer func (#730)

palantir · Dec 5, 2024 · e2d5bcd · e2d5bcd
1 parent b7248da
commit e2d5bcd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/changelog/@unreleased/pr-730.v2.yml b/changelog/@unreleased/pr-730.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: Codecs.GZIP checks error before defer func
+  links:
+  - https://github.com/palantir/conjure-go-runtime/pull/730
diff --git a/conjure-go-contract/codecs/gzip.go b/conjure-go-contract/codecs/gzip.go
@@ -38,14 +38,14 @@ func (c codecGZIP) Accept() string {
 
 func (c codecGZIP) Decode(r io.Reader, v interface{}) (err error) {
 	gzipReader, err := gzip.NewReader(r)
+	if err != nil {
+		return fmt.Errorf("failed to create gzip reader: %w", err)
+	}
 	defer func() {
 		if closeErr := gzipReader.Close(); err == nil && closeErr != nil {
 			err = closeErr
 		}
 	}()
-	if err != nil {
-		return fmt.Errorf("failed to create gzip reader: %s", err.Error())
-	}
 	return c.contentCodec.Decode(gzipReader, v)
 }