feature: Add errors.ConjureErrorDecoder interface & instantiable registry type for customizing error deserialization #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabboud
previously approved these changes
Nov 27, 2024
| } | ||
|
|
||
| // ReflectTypeConjureErrorDecoder is a ConjureErrorDecoder that uses reflection to convert JSON errors to their go types. | ||
| // It stores a mapping of error name to |
There was a problem hiding this comment.
nit: need to finish up the godoc
| ) | ||
|
|
||
| var registry = map[string]reflect.Type{} | ||
| var globalRegistry = NewReflectTypeConjureErrorDecoder() |
policy-bot
bot
dismissed
tabboud’s stale review
Invalidated by push of 94e97db
tabboud
approved these changes
Nov 27, 2024
|
Released v2.88.0 |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #716
Part of addressing palantir/conjure-go#415
Used by palantir/conjure-go#636