Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #317

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Sep 17, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.6.0

Type Description Link
Fix Excavator PRs that apply other refaster rules (e.g. Witchcraft ones) will not also apply baseline refaster rules. palantir/gradle-baseline#827
Improvement Added a new ErrorProne check PreferAssertj to assist migration to AssertJ from legacy test frameworks. It may be necessary to add a dependency on org.assertj:assertj-core in modules which do not already depend on AssertJ. If there's a technical reason that AssertJ cannot be used, PreferAssertj may be explicitly disabled to prevent future upgrades from attempting to re-run the migration. palantir/gradle-baseline#841

2.7.0

Type Description Link
Improvement StrictUnusedVariable now ignores variables prefixed with _ and the suggested fix will rename all unused parameters in public methods instead of removing them palantir/gradle-baseline#833
Improvement ErrorProne will now detect dangerous usage of @RunWith(Suite.class) that references JUnit5 classes, as this can cause tests to silently not run! palantir/gradle-baseline#843

2.8.0

Type Description Link
Fix PreferAssertj provides better replacements fixes palantir/gradle-baseline#850
Improvement Do not run error prone on any code in the build directory palantir/gradle-baseline#853

2.8.1

Type Description Link
Fix Fix hamcrest arrayContainingInAnyOrder conversion palantir/gradle-baseline#859

2.9.0

Type Description Link
Improvement StrictUnusedVariable can only be suppressed with _ prefix palantir/gradle-baseline#854
Improvement StrictUnusedVariable is now an error by default palantir/gradle-baseline#855
Fix The PreferAssertj refactoring will only be applied if you have explicitly opted in (e.g. using baselineErrorProne { patchChecks += 'PreferAssertj' } palantir/gradle-baseline#861

2.9.1

Type Description Link
Fix Error prone will correctly ignore all source files in the build directory and in any generated source directory palantir/gradle-baseline#864
Fix Ensure that StrictUnusedVariable correctly converts previously suppressed variables unused to _ palantir/gradle-baseline#865

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot requested a review from a team as a code owner September 17, 2019 18:53
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 6 times, most recently from 477069c to f2d17b6 Compare September 19, 2019 16:16
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from f2d17b6 to 3fe95cb Compare September 19, 2019 22:43
@bulldozer-bot bulldozer-bot bot merged commit ed098eb into develop Sep 19, 2019
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch September 19, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant