Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes has signed and unsigned comparators #2102

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

schlosna
Copy link
Contributor

@schlosna schlosna commented Sep 4, 2023

Before this PR

Sorting collections of Bytes requires either expensive allocation of byte[] copies or allocations of read only ByteBuffer.

After this PR

==COMMIT_MSG==
Bytes has signed and unsigned comparators
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Sep 4, 2023

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Bytes has signed and unsigned comparators

Check the box to generate changelog(s)

  • Generate changelog entry

Sorry, something went wrong.

schlosna and others added 2 commits September 5, 2023 13:25

Verified

This commit was signed with the committer’s verified signature.
schlosna David Schlosnagle

Verified

This commit was signed with the committer’s verified signature.
schlosna David Schlosnagle
@schlosna schlosna force-pushed the ds/bytes-comparators branch from e1ceba1 to 0b346fc Compare September 5, 2023 17:25
@schlosna schlosna requested a review from carterkozak September 5, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants