[Prework] Landing all 'conjure-lib' API changes Ahead of CodeGen Adoption #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes:
New conjure collections API for:
- unmodifiableList
- addAll
Optimized add and serialize methods on native containers
bmarcaur
force-pushed
the
bmarcaurele/all-api-changes-for-serde-opt
branch
from
33e2bf9 to
bc1e631
Compare
bmarcaur
commented
Nov 22, 2024
conjure-lib/src/main/java/com/palantir/conjure/java/lib/SafeLong.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 22, 2024
conjure-lib/src/main/java/com/palantir/conjure/java/lib/internal/ConjureCollections.java
Outdated
Show resolved
Hide resolved
bmarcaur
force-pushed
the
bmarcaurele/all-api-changes-for-serde-opt
branch
from
dbdff9e to
d70b176
Compare
carterkozak
reviewed
Nov 22, 2024
conjure-lib/src/main/java/com/palantir/conjure/java/lib/internal/ConjureCollections.java
Outdated
Show resolved
Hide resolved
carterkozak
approved these changes
Nov 25, 2024
bulldozer-bot
bot
deleted the
bmarcaurele/all-api-changes-for-serde-opt
branch
|
Released 8.34.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landing these ahead of their adoption in PRs like:
So that there are no concerns with upgrade ordering and accidental transitive drift.