More descriptive error messages when generation fails due to invalid query param type #2474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Deserialization of query parameters of type
<container>[<container>[T]]
are ambiguous. If we encounter an empty value over the wire, we're not able to disambiguate an empty collection from a missing value. We throw an error with the message "unknown type" which isn't as descriptive as it could be.Additionally, we should throw an error earlier during Conjure definition validation defined in this class cc: @kunalrkak
After this PR
==COMMIT_MSG==
More descriptive error messages when generation fails due to invalid query param types
==COMMIT_MSG==
Possible downsides?