Dialogue service generator avoids method references to the same type #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reliance on interfaces to be functional will cause pain if new fields are added in ways that are expected to be otherwise compatible.
Generate changelog in
|
|
Blocked on palantir/dialogue#482 |
carterkozak
commented
Mar 4, 2020
| .map(type -> RUNTIME + ".bodySerDe()::deserializeInputStream") | ||
| .orElseGet(() -> def.getEndpointName().get() + "Deserializer::deserialize")); | ||
| .map(type -> RUNTIME + ".bodySerDe().inputStreamDeserializer()") | ||
| .orElseGet(() -> def.getEndpointName().get() + "Deserializer")); |
There was a problem hiding this comment.
These two lines are the code change.
ferozco
approved these changes
Mar 5, 2020
bulldozer-bot
bot
deleted the
ckozak/avoid_dialogue_deserializer_method_references
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reliance on interfaces to be functional will cause pain if new
fields are added in ways that are expected to be otherwise
compatible.
After this PR
==COMMIT_MSG==
Dialogue service generator avoids method references to the same type
==COMMIT_MSG==