Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externally Publish conjure-postman-core for use at runtime #518

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jsklan
Copy link

@jsklan jsklan commented Jan 2, 2023

I'm not 100% clear this is how this works, but I wanted to start a discussion focused on the required code changes.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/conjure-postman, @jsklan! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Jan 2, 2023

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Externally Publish conjure-postman-core for use at runtime

I'm not 100% clear this is how this works, but I wanted to start a discussion focused on the required code changes.

Check the box to generate changelog(s)

  • Generate changelog entry

@jsklan jsklan marked this pull request as draft January 2, 2023 23:19
@jsklan
Copy link
Author

jsklan commented Jan 2, 2023

@ahggns I'm not too familiar with gradle, but essentially I'm trying to make this sub-library usable externally. From what I can tell, currently you can only use conjure-postman either 1) as an executable or 2) at build time as a conjureGenerator with gradle-conjure. This would let folks use its internal functions at runtime in their other projects. Is this the correct change we need to make this possible?

@@ -14,6 +14,7 @@
* limitations under the License.
*/

apply plugin: 'com.palantir.external-publish-application-dist'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants