Upgrade to Hyper 1 #177
Merged
Upgrade to Hyper 1 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
sfackler
commented
Apr 22, 2024
| @@ -1,212 +0,0 @@ | |||
| // Copyright 2020 Palantir Technologies, Inc. | |||
There was a problem hiding this comment.
This was just dead code
pierceforte
previously approved these changes
May 24, 2024
Comment on lines
+147
to
+159
| loop { | ||
| match ready!(this.body.as_mut().poll_frame(cx)) | ||
| .transpose() | ||
| .map_err(Error::internal_safe)? | ||
| { | ||
| Some(frame) => { | ||
| if let Ok(data) = frame.into_data() { | ||
| return Poll::Ready(Some(Ok(data))); | ||
| } | ||
| } | ||
| None => return Poll::Ready(None), | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we have some delay in this loop?
There was a problem hiding this comment.
The poll_frame is going out to the network so we should be good.
conjure-runtime/src/body.rs
Outdated
Comment on lines
249
to
252
| if self.done { | ||
| true | ||
| } else { | ||
| self.body.is_end_stream() |
There was a problem hiding this comment.
nit: self.done || self.body.is_end_stream()
policy-bot
bot
dismissed
pierceforte’s stale review
Invalidated by push of 93b50f0
|
Needs a re-+1 |
pierceforte
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump rustls.