[stacked] Box streaming request bodies #268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Streaming request bodies were passed by reference at the
Client
level, while they were passed by value in the generated Conjure code. This complicated codegen and caused inconsistencies in behavior betweenconjure-codegen
andconjure-macros
.After this PR
==COMMIT_MSG==
Streaming request bodies are now passed by value to the client.
==COMMIT_MSG==
We could go further and implement a bigger change to handle palantir/conjure-rust-runtime#146. However, this would complicate the interface even more and be only possible in the async client. Given that we don't have any use cases for full-duplex communications via Conjure clients it doesn't seem worth it.
Closes #259