Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of Smile maps with UUID keys #386

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

sfackler
Copy link
Member

Before this PR

The Smile serde Deserializer used for map keys incorrectly reported itself as not "human readable", which causes UUID deserialization logic to expect raw bytes instead of the string encoding. While maps keyed by UUIDs would serialize properly, they would not deserialize, failing with

Error(Custom("invalid value: string \"820eea12-894b-4e6e-96a0-668b79b9edb4\", expected a base64 string"))

After this PR

==COMMIT_MSG==
==COMMIT_MSG==

We now override is_human_readable to true in the key deserializer instead of delegating to the underlying Deserializer.

@sfackler sfackler requested a review from a team September 18, 2024 14:31
@changelog-app
Copy link

changelog-app bot commented Sep 18, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix deserialization of Smile maps with UUID keys

Check the box to generate changelog(s)

  • Generate changelog entry

@sfackler sfackler merged commit 94d6b3e into master Sep 18, 2024
5 checks passed
@sfackler sfackler deleted the fix-smile-uuid-key branch September 18, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants