Fix deserialization of Smile maps with UUID keys #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The Smile serde
Deserializer
used for map keys incorrectly reported itself as not "human readable", which causes UUID deserialization logic to expect raw bytes instead of the string encoding. While maps keyed by UUIDs would serialize properly, they would not deserialize, failing withAfter this PR
==COMMIT_MSG==
==COMMIT_MSG==
We now override
is_human_readable
totrue
in the key deserializer instead of delegating to the underlying Deserializer.