Safer buildQueryString (#94)

palantir · Jan 16, 2020 · b382246 · b382246
1 parent 5cf0f74
commit b382246
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/changelog/@unreleased/pr-94.v2.yml b/changelog/@unreleased/pr-94.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: Check that queryArguments is non-null before iterating over keys
+  links:
+    - https://github.com/palantir/conjure-typescript-runtime/pull/94
diff --git a/packages/conjure-client/src/fetchBridge/fetchBridge.ts b/packages/conjure-client/src/fetchBridge/fetchBridge.ts
@@ -191,6 +191,10 @@ export class FetchBridge implements IHttpApiBridge {
     }
 
     private buildQueryString(data: { [key: string]: any }) {
+        if (data == null) {
+            return "";
+        }
+
         const query: string[] = [];
         for (const key of Object.keys(data)) {
             const value = data[key];