Behavior of pathParamString and pathParamAliasString's empty cases is unclear #300
Comments
sfackler
added a commit
that referenced
this issue
Feb 5, 2020
Closes #300 These are ignored by every single consumer of the verification server: https://github.com/palantir/conjure-rust-runtime/blob/master/conjure-verification/ignored-test-cases.yml#L99-L104 https://github.com/palantir/conjure-java-runtime/blob/develop/conjure-java-client-verifier/src/test/resources/ignored-test-cases.retrofit.yml#L123-L127 https://github.com/palantir/conjure-java-runtime/blob/develop/conjure-java-client-verifier/src/test/resources/ignored-test-cases.jersey.yml#L86-L90 https://github.com/palantir/conjure-typescript-runtime/blob/b1005c04a051fc44907d45e2e0e96c49b1427702/packages/conjure-client/src/__integTest__/tests.ts#L34-L35 https://github.com/palantir/conjure-go/blob/develop/conjure-go-verifier/ignored-test-cases.yml#L108-L111 https://github.com/palantir/conjure-python/blob/develop/conjure-python-verifier/resources/ignored_test_cases.yml#L118-L122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
The path param client tests include two cases that generate an empty path segment:
https://github.com/palantir/conjure-verification/blob/develop/master-test-cases.yml#L791
https://github.com/palantir/conjure-verification/blob/develop/master-test-cases.yml#L799
The client I'm working on rendered those paths as
/single-path-param/pathParamString/0/and/single-path-param/pathParamAliasString/0/, but those 404'd on the verification server.What did you want to happen?
What is the expected behavior here? The wire spec doesn't have any discussion of special casing empty path params, and the trailing
/is what I'd expect this to end up with.The text was updated successfully, but these errors were encountered: