Excavator: Format Java files #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svc-excavator-bot
force-pushed
the
roomba/format
branch
from
85e8e05 to
6455e88
Compare
svc-excavator-bot
force-pushed
the
roomba/format
branch
from
6455e88 to
584b6bc
Compare
svc-excavator-bot
force-pushed
the
roomba/format
branch
4 times, most recently
from
6669607 to
959e3f9
Compare
svc-excavator-bot
force-pushed
the
roomba/format
branch
from
959e3f9 to
0b30dee
Compare
dansanduleac
reviewed
Apr 6, 2020
Comment on lines
+70
to
+76
| ImmutableMap.of( | ||
| "http", | ||
| "POST /" + endpointName, | ||
| "returns", | ||
| typeName, | ||
| "args", | ||
| ImmutableMap.of("body", typeName))); |
There was a problem hiding this comment.
as discussed before #311 (comment) this is not great but I think we can move forward with the PR for now.
We are tracking the issue at palantir/palantir-java-format#204
dansanduleac
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/format check.
To enable or disable this check, please contact the maintainers of Excavator.