Readme: fix link to RFC 004 #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
approved these changes
Nov 8, 2021
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
|
Still relevant! |
ferozco
approved these changes
Jan 10, 2022
|
Looks like maybe checks don't work on this repo? Or do I have to do something special to make them work? |
|
ya looks like something is up with the repo. I just power merged the readme change for now. @carterkozak @CRogers for SA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The link from the readme to RFC 004 is wrong (it uses the wrong branch name).
After this PR
==COMMIT_MSG==
Readme: fix link to RFC 004
==COMMIT_MSG==
Possible downsides?
Maybe we wanted to switch the default branch in palantir/conjure instead? Either way, I think it's worth fixing this unless that is imminent.