Add support for aarch64 #522
Conversation
This causes a breaking change for any direct consumers as the coordinates for the osx bundle will be changing such that there is now a: osx-x86_64 package and osx-aarch64 package This adds a bit more safety to ensure that consumers don't inadvertently grab the incorrect package.
Generate changelog in
|
| futures = "0.1.15" | ||
| hyper = "0.12.2" | ||
| hyper-openssl = "0.6" | ||
| http-zipkin = "0.1" | ||
| lazy_static = "1.0" | ||
| log = "0.4" | ||
| mime = "0.3" | ||
| openssl = "0.10" | ||
| openssl = { version = "0.10", features = ["vendored"] } |
There was a problem hiding this comment.
This little gem is necessary for cross compilation.
| @@ -9,15 +9,15 @@ license-file = "../LICENSE" | |||
| base64 = "0.9" | |||
| bytes = "0.4" | |||
| crossbeam = "0.3" | |||
| flate2 = "1.0" | |||
| flate2 = "1.0.24" | |||
There was a problem hiding this comment.
This bumps us to a version which has a native miniz implementation rather than the C implementation which fails to link.
| @@ -1,1863 +1,1893 @@ | |||
| # This file is automatically @generated by Cargo. | |||
| # It is not intended for manual editing. | |||
| version = 3 | |||
There was a problem hiding this comment.
I'll be honest...I don't know enough Rust to know if it's fine that this changed as much as it did.
…rification into feature/add-aarch-64 * 'feature/add-aarch-64' of github.com:palantir/conjure-verification: Add generated changelog entries
|
Hi friends! Do you think you could remove me as reviewer from this one? Don't have the permission to do so :D |
|
This is pretty beyond repair, I spent way too much time trying to fix it, rust diverged too much from when this repo was originally crafted. |
Before this PR
After this PR
==COMMIT_MSG==
Add support for aarch64
This causes a breaking change for any direct consumers as the
coordinates for the osx bundle will be changing such that there
is now a:
osx-x86_64 package
and
osx-aarch64 package
This adds a bit more safety to ensure that consumers don't inadvertently
grab the incorrect package.
Also bump the rust version to 1.63.0 which is the latest version, just for good measure.
==COMMIT_MSG==
Possible downsides?