CachingFallbackDnsResolver logs at debug level (#2283)

CachingFallbackDnsResolver logs at debug level
palantir · May 17, 2024 · 4182ff2 · 4182ff2
1 parent b1e5ddf
commit 4182ff2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/changelog/@unreleased/pr-2283.v2.yml b/changelog/@unreleased/pr-2283.v2.yml
@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: CachingFallbackDnsResolver logs at debug level
+  links:
+  - https://github.com/palantir/dialogue/pull/2283
diff --git a/dialogue-clients/src/main/java/com/palantir/dialogue/clients/CachingFallbackDnsResolver.java b/dialogue-clients/src/main/java/com/palantir/dialogue/clients/CachingFallbackDnsResolver.java
@@ -58,9 +58,11 @@ public ImmutableSet<InetAddress> resolve(String hostname) {
             ImmutableSet<InetAddress> maybeFallback = fallbackCache.getIfPresent(hostname);
             if (maybeFallback != null) {
                 lookupFallback.mark();
-                log.info(
-                        "DNS resolution failed for host '{}', however fallback addresses are present in the cache",
-                        UnsafeArg.of("hostname", hostname));
+                if (log.isDebugEnabled()) {
+                    log.debug(
+                            "DNS resolution failed for host '{}', however fallback addresses are present in the cache",
+                            UnsafeArg.of("hostname", hostname));
+                }
                 return maybeFallback;
             } else {
                 lookupFailure.mark();