Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmptyBodyDeserializer does not handle error responses #574

Closed
pkoenig10 opened this issue Mar 27, 2020 · 0 comments · Fixed by #575
Closed

EmptyBodyDeserializer does not handle error responses #574

pkoenig10 opened this issue Mar 27, 2020 · 0 comments · Fixed by #575
Labels
bug Something isn't working

Comments

@pkoenig10
Copy link
Member

What happened?

A void endpoint that returned an error did not result in an exception. The EmptyBodyDeserializer does not decode errors:

public Void deserialize(Response response) {
// We should not fail if a server that previously returned nothing starts returning a response
response.close();
return null;
}

@iamdanfox iamdanfox added the bug Something isn't working label Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants