Properly handle errors on void methods #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
reviewed
Mar 27, 2020
| return null; | ||
| } finally { | ||
| // We should not fail if a server that previously returned nothing starts returning a response | ||
| response.close(); |
There was a problem hiding this comment.
could use try with resources here if you like
iamdanfox
reviewed
Mar 27, 2020
| @Test | ||
| public void testEmptyResponse_failure() { | ||
| TestResponse response = new TestResponse(); | ||
| response.code = 400; |
There was a problem hiding this comment.
if you merge in develop, I've just changed this to be a setter method, so new TestResponse().code(400)
iamdanfox
approved these changes
Mar 27, 2020
added 2 commits
March 27, 2020 12:44
…to fo/empty-body-error
carterkozak
approved these changes
Mar 27, 2020
|
Released 1.2.3 |
|
Thanks @carterkozak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #574
Before this PR
We would silently drop errors on endpoints that did not expect a response
After this PR
==COMMIT_MSG==
Properly handle errors on void methods
==COMMIT_MSG==
Possible downsides?
N/A