Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients.callBlocking provides a default implementation #1106

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

carterkozak
Copy link
Contributor

This provides safety in case a newer target is used than implementation,
which can occur when a project pulls in generated bindings with a
newer target dep.
Long term we should consider using constraints to avoid version
slip between jars produced by the same repository.

==COMMIT_MSG==
Clients.callBlocking provides a default implementation for cross-version compatibility
==COMMIT_MSG==

This provides safety in case a newer target is used than implementation,
which can occur when a project pulls in generated bindings with a
newer target dep.
Long term we should consider using constraints to avoid version
slip between jars produced by the same repository.
@changelog-app
Copy link

changelog-app bot commented Jan 28, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Clients.callBlocking provides a default implementation for cross-version compatibility

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from CRogers January 28, 2021 19:22
Copy link
Contributor

@jkozlowski jkozlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's unblock the rest of the work, and we can come back to this. It's scary

@bulldozer-bot bulldozer-bot bot merged commit e80ed0f into develop Jan 29, 2021
@bulldozer-bot bulldozer-bot bot deleted the ckozak/default_callBlocking branch January 29, 2021 13:00
@svc-autorelease
Copy link
Collaborator

Released 1.96.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants