Support RequestBody#contentLength. #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
approved these changes
Apr 28, 2021
jkozlowski
commented
Apr 28, 2021
| {"traceId":"3519228122fee79e","parentSpanId":"b9eede02cfc9a230","spanId":"fc414565b6a32ddd","type":"LOCAL","operation":"Dialogue-request-attempt initial","startTimeMicroSeconds":1619611357982666,"durationNanoSeconds":1428971,"metadata":{}} | ||
| {"traceId":"3519228122fee79e","parentSpanId":"76a3f96c2bd32ebb","spanId":"257e95ea327f70b4","type":"LOCAL","operation":"Dialogue-RetryingChannel","startTimeMicroSeconds":1619611357020816,"durationNanoSeconds":964010756,"metadata":{"serviceName":"service","endpointName":"endpoint","failures":"5","channel":"my-channel"}} | ||
| {"traceId":"3519228122fee79e","parentSpanId":null,"spanId":"4791d408917316f4","type":"LOCAL","operation":"Dialogue: request service#endpoint","startTimeMicroSeconds":1619611357020205,"durationNanoSeconds":970171438,"metadata":{"endpointService":"service","endpointName":"endpoint","http.method":"POST","channel":"my-channel","mesh":"false","outcome":"failure","http.status_code":"429"}} | ||
| {"traceId":"3519228122fee79e","parentSpanId":"866a99f10ab0c9b9","spanId":"cff8c71cc0a4de65","type":"LOCAL","operation":"dialogue-RetryingChannel-scheduler","startTimeMicroSeconds":1619611357982457,"durationNanoSeconds":8481191,"metadata":{}} |
There was a problem hiding this comment.
Thoughts on what happened?
There was a problem hiding this comment.
Feels like this should've been there from the start?
There was a problem hiding this comment.
My guess is that the scheduler runnable is still executing while the test completes, which allows the test to record spans up to, but not including the final dialogue-RetryingChannel-scheduler.
In both before and after, we have the correct number of Dialogue-request-attempt and Dialogue-request-attempt initial spans.
|
Released 1.120.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
No way to specify content length of body directly.
After this PR
==COMMIT_MSG==
RequestBody supports optional content length.
==COMMIT_MSG==
Possible downsides?
More API. It's kinda already API, for feign replacement, so likely makes sense to support directly. Also useful for #1222