Enable incremental annotation processing #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
pkoenig10
commented
May 3, 2021
| annotationProcessor 'org.immutables:value' | ||
| compileOnly 'org.immutables:value::annotations' | ||
| annotationProcessor 'org.derive4j:derive4j' | ||
| compileOnly 'org.derive4j:derive4j-annotation' | ||
|
|
||
| testAnnotationProcessor 'org.immutables:value' | ||
| testCompileOnly 'org.immutables:value::annotations' | ||
| testCompileOnly 'net.ltgt.gradle.incap:incap' |
There was a problem hiding this comment.
Necessary because the IncrementalAnnotationProcessor annotation has class retention. This is acceptable because downstream consumers do not compile against the annotation processor, see https://github.com/tbroyer/gradle-incap-helper#usage.
carterkozak
approved these changes
May 3, 2021
|
Released 1.124.0 |
|
Thanks! How does this actually work, and where was this causing issues? |
carterkozak
added a commit
to palantir/tritium
that referenced
this pull request
May 13, 2021
Based loosely on palantir/dialogue#1231 I opted against using annotation processors for simplicity. I had minor issues with intellij, and generally find META-INF files easier to reason about that annotation processors which write one-line files. Documentation for incremental processing can be found here: https://docs.gradle.org/current/userguide/java_plugin.html#sec:incremental_annotation_processing It's possible that this feature may cause issues if we attempt to instrument types that are genereated from other annotation processors, however that is somewhat unlikely, and the docs describe that as a valid case for `isolating` configuration.
carterkozak
added a commit
to palantir/tritium
that referenced
this pull request
May 13, 2021
Based on palantir/dialogue#1231 I opted against using annotation processors for simplicity. I had minor issues with intellij, and generally find META-INF files easier to reason about that annotation processors which write one-line files. Documentation for incremental processing can be found here: https://docs.gradle.org/current/userguide/java_plugin.html#sec:incremental_annotation_processing It's possible that this feature may cause issues if we attempt to instrument types that are genereated from other annotation processors, however that is somewhat unlikely, and the docs describe that as a valid case for `isolating` configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The Dialogue annotation processor does not support incremental compilation.
After this PR
The Dialogue annotation processor does support incremental compilation.