Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lists of primitives. #1249

Merged
merged 3 commits into from
May 10, 2021
Merged

Conversation

jkozlowski
Copy link
Contributor

@jkozlowski jkozlowski commented May 10, 2021

Before this PR

Need a custom param encoder for List.

After this PR

==COMMIT_MSG==
Support list-of-primitives header/query params.
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented May 10, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Support multi-value primitive params.

Check the box to generate changelog(s)

  • Generate changelog entry

@jkozlowski jkozlowski requested a review from tetigi May 10, 2021 12:53
@jkozlowski jkozlowski marked this pull request as ready for review May 10, 2021 12:53
@policy-bot policy-bot bot requested a review from robert3005 May 10, 2021 12:54
_request.putAllHeaderParams(
"Custom-Header1",
customListHeader.stream()
.map(_parameterSerializer::serializeString)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debated adding some shared code for this, but generally in favour of generating as much as we can, as that's compile-time validation and breakable, as opposed to library code.

Copy link

@tetigi tetigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bulldozer-bot bulldozer-bot bot merged commit fffe882 into develop May 10, 2021
@bulldozer-bot bulldozer-bot bot deleted the jakubk/support-collections branch May 10, 2021 15:52
@svc-autorelease
Copy link
Collaborator

Released 1.128.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants