Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency limiter uses #compareAndSet. #1307

Merged
merged 7 commits into from
Jul 9, 2021

Conversation

jkozlowski
Copy link
Contributor

@jkozlowski jkozlowski commented Jul 8, 2021

Before this PR

Not using #compareAndSet can lead to releasing more permits than limit under load.

After this PR

==COMMIT_MSG==
Use #compareAndSet when checking limits.
==COMMIT_MSG==

Possible downsides?

* Not using #compareAndSet can lead to releasing more permits than limit
  under load.
@changelog-app
Copy link

changelog-app bot commented Jul 8, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Use #compareAndSet when checking limits.

Check the box to generate changelog(s)

  • Generate changelog entry

So much better

Co-authored-by: Carter Kozak <ckozak@ckozak.net>
@jkozlowski jkozlowski marked this pull request as ready for review July 9, 2021 12:45
@bulldozer-bot bulldozer-bot bot merged commit 410ca36 into develop Jul 9, 2021
@bulldozer-bot bulldozer-bot bot deleted the jakubk/off-to-the-races branch July 9, 2021 12:59
@svc-autorelease
Copy link
Collaborator

Released 2.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants